fix(renderer): sanitize embedded newlines in Output.add_line - #447
Merged
Conversation
phanen
marked this pull request as draft
July 5, 2026 16:03
Contributor
Author
|
Not sure if there any best way to fix. I originally notice question dialog won't show up if some error happened before that. Maybe a schema error event in opencode side will produce another bug, I haven't confirm. |
phanen
commented
Jul 5, 2026
phanen
force-pushed
the
fix/santinize-newlines
branch
2 times, most recently
from
July 6, 2026 06:55
46d0592 to
d445197
Compare
phanen
force-pushed
the
fix/santinize-newlines
branch
from
July 6, 2026 14:14
d445197 to
833e09d
Compare
phanen
marked this pull request as ready for review
July 7, 2026 05:16
Contributor
Author
|
The prompt to test: |
Owner
|
The fix make sense to me. Thanks for the PR |
disrupted
pushed a commit
to disrupted/opencode-native.nvim
that referenced
this pull request
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reproduce, maybe just ask opencode to: